PPM: implement service.targetPort as configurable#648
Merged
Conversation
|
|
tnederlof
reviewed
Mar 21, 2025
glin
approved these changes
Mar 27, 2025
| # -- The Service port. This is the port your service will run under. | ||
| port: 80 | ||
| # -- The port to forward to on the Package Manager pod. Also see pod.port | ||
| targetPort: 4242 |
Contributor
There was a problem hiding this comment.
Besides service.targetPort and pod.port, there are a bunch of other 4242 references in the values, like the config.HTTP.Listen = :4242 setting, liveness/startup probe. I assume users would have to find-and-replace all 4242 references manually to fully change the running port?
Is it possible to use a template variable here so you only have to set 4242 once somewhere?
Otherwise this is fine of course, as it's still better than what we had before.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
service.targetPort was hard coded as port 4242. Modifed this to be a configurable value to support use cases when customer requires routing to alternate port.
Also implemented
pod.portandpod.hostAliases